-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Replace dead link in README.md. #29699
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @lephleg! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Thanks for your contribution @lephleg. One of the checks is failing. I believe you'll need to run the Commit and push that change and the check should pass. |
e7c2bee
to
9ea2c71
Compare
@talldan thanks for the assistance! I tried the Following @mkaz's extended guide along with the documentation Contributor's Guide I find no reference to additional steps required in order to update an existing document. I'll have to dig in to the build script itself. |
It's because you are modifying the built MD file. You'll have to update the link in |
9ea2c71
to
d4981c0
Compare
Oh damn, I didn't realise that was generated. Thanks for the guidance @swissspidy! Clean-pushed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @lephleg
Congratulations on your first merged pull request, @lephleg! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Fixes #29696.
Alters an irrelevant link in the i18n README.md file to a more proper entry.